----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/#review185243 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mesos.hpp Lines 590 (patched) <https://reviews.apache.org/r/62197/#comment261545> I think that this parameter can be a `const std::string&` instead of an `Option`, which would allow us to get rid of the conditional in the function body. - Greg Mann On Sept. 12, 2017, 7:47 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62197/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 7:47 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad. > > > Bugs: MESOS-7877 > https://issues.apache.org/jira/browse/MESOS-7877 > > > Repository: mesos > > > Description > ------- > > These new overloads make it possible to specify a framework ID, executor > resources as a proto, and the executor ID also as a proto. > > > Diffs > ----- > > src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 > > > Diff: https://reviews.apache.org/r/62197/diff/5/ > > > Testing > ------- > > `make check` still passes on GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
