----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185677 -----------------------------------------------------------
Patch looks great! Reviews applied: [62333, 62214] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 18, 2017, 3:10 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62214/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 3:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > ------- > > This linter runs when changes on a JavaScript file are being committed. > The linter used is ESLint with a configuration based on our current JS > code base. The linter and its dependencies (i.e. Node.js) are installed > in a environment using Virtualenv and then Nodeenv. > > > Diffs > ----- > > src/webui/.eslintrc.js PRE-CREATION > src/webui/.gitignore PRE-CREATION > src/webui/bootstrap PRE-CREATION > src/webui/pip-requirements.txt PRE-CREATION > support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 > > > Diff: https://reviews.apache.org/r/62214/diff/2/ > > > Testing > ------- > > Following this commit, I have tried to commit a change on a JavaScript file > and checked that ESLinter was correctly running. > > > Thanks, > > Armand Grillet > >