----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review186031 -----------------------------------------------------------
3rdparty/stout/include/stout/protobuf.hpp Lines 413 (patched) <https://reviews.apache.org/r/59987/#comment262403> Not sure if it is cleaner to parse the map here because we're duplicating the `apply_visitor` call here. Another possible implementation is to move this into `parse()` with an additional `bool mapField = false` parameter. In `parse()`, if `mapFiled` is set to true, we can set up the key and replace `message` by a `Message` pointer to the value before passing it into `apply_visitor`. Thoughts? 3rdparty/stout/include/stout/protobuf.hpp Lines 421 (patched) <https://reviews.apache.org/r/59987/#comment262404> Although it seems that `*entry` would not be managed by `repeated_ref` after `repeated_ref.Add(*entry)`, I cannot find such a guarantee from protobuf's documentation. How about doing `entry = reflection->AddMessage(message, field)` here instead, so that we don't need `repeated_ref`, and the memory management is consistent with the other cases? 3rdparty/stout/include/stout/protobuf.hpp Line 607 (original), 640 (patched) <https://reviews.apache.org/r/59987/#comment262406> How about a partial specialization for `google::protobuf::Map`? 3rdparty/stout/include/stout/protobuf.hpp Line 868 (original), 901 (patched) <https://reviews.apache.org/r/59987/#comment262408> How about iterating through `reflection->GetRepeatedMessage()` here instead? - Chun-Hung Hsiao On July 4, 2017, 2:43 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59987/ > ----------------------------------------------------------- > > (Updated July 4, 2017, 2:43 a.m.) > > > Review request for mesos, Anand Mazumdar and Zhitao Li. > > > Bugs: MESOS-7656 > https://issues.apache.org/jira/browse/MESOS-7656 > > > Repository: mesos > > > Description > ------- > > Map is a feature of proto2 syntax, but it can only be compiled > with proto3 compiler, see the following discussion for details: > https://groups.google.com/forum/#!topic/protobuf/p4WxcplrlA4 > We have already upgraded the compiler from 2.6.1 to 3.3.0 in > MESOS-7228, however, to use protobuf map in Mesos code, we also > need to add the protobuf map support to the code in Mesos for > converting protobuf message to JSON object and parsing JSON > object as protobuf message, that is what I have done in this patch. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > 15690b66cc4ae0c1bf2c2176d73c385ca75d3c20 > > > Diff: https://reviews.apache.org/r/59987/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
