----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/#review186113 -----------------------------------------------------------
Fix it, then Ship it! Look great! Only found some nits. src/Makefile.am Lines 1140 (patched) <https://reviews.apache.org/r/61528/#comment262545> Move this below `resource_provider/registry.proto` but before `resource_provider/storage/provider.hpp` to follow the sorting rules in `Makefile.am`. src/resource_provider/registrar.cpp Lines 20 (patched) <https://reviews.apache.org/r/61528/#comment262547> Put this before `<deque>`. src/resource_provider/registrar.cpp Lines 138-149 (patched) <https://reviews.apache.org/r/61528/#comment262551> Any reason why these functions are implemented here? I'd rather have them move above the constructor of `AdmitResourceProvider` to be consistent and follow the order of classes in the header. - Jan Schlicht On Sept. 25, 2017, 12:27 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61528/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 12:27 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7555 > https://issues.apache.org/jira/browse/MESOS-7555 > > > Repository: mesos > > > Description > ------- > > This patch adds a registry and registrar interface for resource > provider managers. The registrar interface is modelled after the > master registrar and supports similar operations. Currently a single, > LevelDB-backed registrar is implemented which we plan to use for > resource provider managers in agents. > > Current the registry allows to add and remove resource provider IDs. > > > Diffs > ----- > > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/resource_provider/registrar.hpp PRE-CREATION > src/resource_provider/registrar.cpp PRE-CREATION > src/resource_provider/registry.hpp PRE-CREATION > src/resource_provider/registry.proto PRE-CREATION > src/slave/paths.hpp d021e6b85a2e5823ea088d65faf9cd85cfb57e28 > src/slave/paths.cpp e8724bf3e382211b5882728b86575de75981307f > src/tests/resource_provider_manager_tests.cpp > 3bc56b51526e9dd188423f7349e74246c3295c77 > > > Diff: https://reviews.apache.org/r/61528/diff/11/ > > > Testing > ------- > > Tested on a number of platforms on internal CI. > > > Thanks, > > Benjamin Bannier > >
