> On Sept. 19, 2017, 11:13 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp > > Lines 1121 (patched) > > <https://reviews.apache.org/r/62381/diff/2/?file=1828610#file1828610line1139> > > > > I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here.
This test passes on Windows. Is it really necessary to use `TEST_F_TEMP_DISABLED_ON_WINDOWS`? - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/#review185744 ----------------------------------------------------------- On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62381/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 5:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gastón > Kleiman, haosdent huang, and Lukas Loesche. > > > Bugs: MESOS-4812 > https://issues.apache.org/jira/browse/MESOS-4812 > > > Repository: mesos > > > Description > ------- > > Mesos can enter namespaces via `setns` for launched subprocesses, hence > we got rid of `docker exec` for command health checks. This change > leads to more stable command health checks by making them independent > from docker daemon that might hang. Also, this commit fixes the issue > with incorrect escaping of quote characters in command health checks. > > > Diffs > ----- > > src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 > src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc > > > Diff: https://reviews.apache.org/r/62381/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
