> On Sept. 26, 2017, 12:47 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Line 889 (original) > > <https://reviews.apache.org/r/62479/diff/1/?file=1832428#file1832428line889> > > > > So sending a shutdown message now is only for shutting down the > > tasks/executors? Can we add/update a comment on the ShutdownSlaveMessage > > proto?
Looks like the `ShutdownMessage` already has this comment i.e., it only shutsdown tasks/executor before committing suicide. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62479/#review186180 ----------------------------------------------------------- On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62479/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 8:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7445 > https://issues.apache.org/jira/browse/MESOS-7445 > > > Repository: mesos > > > Description > ------- > > This change removes the logic of removing the latest symlink on > receiving the shutdown message from the Mesos master. This ensures > that agents come back with the same agent ID upon a successful > shutdown similar to the behavior when they come back post a reboot. > > > Diffs > ----- > > src/slave/slave.cpp 01020a624bdd67ee6371f607d897ad71a2cdcc82 > > > Diff: https://reviews.apache.org/r/62479/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
