----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review186483 -----------------------------------------------------------
src/scheduler/flags.hpp Lines 57-59 (patched) <https://reviews.apache.org/r/62594/#comment263056> s/kept in in sync/kept in sync/ Also, this seems bad :) (also for modules_dir) I wonder if we have a ticket for eliminating this code duplication thru common inheritance? src/scheduler/scheduler.cpp Lines 226 (patched) <https://reviews.apache.org/r/62594/#comment263058> Indented too far. src/scheduler/scheduler.cpp Lines 327 (patched) <https://reviews.apache.org/r/62594/#comment263069> See my comment in another review in this chain regarding underscores on similar variables within a scope. We should probably just give this one a new name. src/scheduler/scheduler.cpp Line 527 (original), 594 (patched) <https://reviews.apache.org/r/62594/#comment263060> Hmmm... is this CHECK correct? Since this continuation is registered as an `onAny` callback, couldn't the future be in DISCARDED state? You do handle the discarded case in your new continuation. - Greg Mann On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62594/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 10:54 p.m.) > > > Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, > Greg Mann, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-8021 > https://issues.apache.org/jira/browse/MESOS-8021 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 > src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c > > > Diff: https://reviews.apache.org/r/62594/diff/1/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
