----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/#review186390 -----------------------------------------------------------
include/mesos/authentication/http/authenticatee.hpp Lines 32-33 (patched) <https://reviews.apache.org/r/62587/#comment262946> An implementation isn't necessarily thin, what about e.g., An abstraction enabling any HTTP API consumer to authenticate. include/mesos/authentication/http/authenticatee.hpp Lines 38 (patched) <https://reviews.apache.org/r/62587/#comment262943> `= default` include/mesos/authentication/http/authenticatee.hpp Lines 41-44 (patched) <https://reviews.apache.org/r/62587/#comment262944> Since we are in the generic interface where there are no caches, I'd suggest to make this comment more generic, e.g., `Reset the authenticatee to its initial state`. include/mesos/authentication/http/authenticatee.hpp Lines 48-49 (patched) <https://reviews.apache.org/r/62587/#comment262945> Since our Doxygen setup uses `JAVADOC_AUTOBRIEF` which makes the first paragraph a brief description, can we add one here?, e.g., Create a HTTP request for authentication. - Benjamin Bannier On Sept. 27, 2017, 12:54 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62587/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 12:54 a.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and > Kapil Arya. > > > Bugs: MESOS-8016 > https://issues.apache.org/jira/browse/MESOS-8016 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > include/mesos/authentication/http/authenticatee.hpp PRE-CREATION > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > > > Diff: https://reviews.apache.org/r/62587/diff/1/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >