----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ -----------------------------------------------------------
(Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description ------- Document that some FetcherTest tests won't work on Windows platform. Tests for tar, gzip, and such won't be working on Windows for the time being. Thoughts are to provide this capability to the Fetcher in a cross-platform manner via a programmatic code library rather than Linux-specific command line tools (tar, gzip, etc). In the short term, zip and unzip will work since PowerShell can support that natively. Fix FetcherTest.AbsoluteCustomSubdirectoryFails on Windows platform. Test FetcherTest.InvalidUser can't work on Windows for now. Fix test FetcherTest.NonExistingFile on Windows platform. Fix test FetcherTest.AbsolutePath on Windows platform. Fix test FetcherTest.RelativeFilePath on Windows platform. Fix test FetcherTest.OSNetUriTest on Windows platform. Fix test FetcherTest.OSNetUriSpaceTest on Windows platform. Fix test FetcherTest.FileLocalhostURI on Windows platform. Fix test FetcherTest.Unzip_ExtractFile on Windows platform. Fix test FetcherTest.Unzip_ExtractInvalidFile on Windows platform. Fix test Unzip_ExtractFileWithDuplicatedEntries on Windows platform. Fix test FetcherTest.UseCustomOutputFile on Windows platform. Diffs (updated) ----- src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d src/slave/containerizer/fetcher.cpp ba5b0979aa427c5b3dbacf39661d6027da13e0d6 src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 Diff: https://reviews.apache.org/r/60628/diff/2/ Changes: https://reviews.apache.org/r/60628/diff/1-2/ Testing ------- See upstream. Thanks, Jeff Coffler