----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review187345 -----------------------------------------------------------
What is the reason that the HDFS files are now made to build on Windows, but (AFAICT) not actually enabled for support? Is there an immediate plan to support HDFS, and if not, why start building the files? src/launcher/fetcher.cpp Lines 267-268 (patched) <https://reviews.apache.org/r/60624/#comment264275> If so, this needs a TODO and an associated issue. The form should be: // TODO(coffler): Fix Windows chmod handling, see MESOS-1234. Or an explanation of why we can just ignore this on Windows (exe bit doesn't matter!). src/launcher/fetcher.cpp Lines 485-487 (patched) <https://reviews.apache.org/r/60624/#comment264276> Ditto style comment above. src/launcher/fetcher.cpp Lines 564-569 (original), 571-579 (patched) <https://reviews.apache.org/r/60624/#comment264277> Ditto style comment above. For ownership, we probably need a separate issue tracking its implementation. src/tests/hdfs_tests.cpp Lines 55-57 (original), 55-60 (patched) <https://reviews.apache.org/r/60624/#comment264278> Ditto above on style / also exe bit doesn't map on Windows, so we can saefly ignore this logic. src/tests/hdfs_tests.cpp Line 67 (original), 70 (patched) <https://reviews.apache.org/r/60624/#comment264279> All these disabled tests need an issue and note why they're disabled, as this patch is bringing the file in. - Andrew Schwartzmeyer On Oct. 5, 2017, 9:04 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60624/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2017, 9:04 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Note that tests are disabled for Windows due to dependence on 'sh' > shell. > > > Diffs > ----- > > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d > src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e > src/tests/hdfs_tests.cpp e7154c75e663d9a98bec48be42a59b65c96f9515 > > > Diff: https://reviews.apache.org/r/60624/diff/2/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
