----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62836/#review187716 -----------------------------------------------------------
src/launcher/default_executor.cpp Line 894 (original), 903 (patched) <https://reviews.apache.org/r/62836/#comment264765> Should we set this true even if the container is already in `killing`? - Vinod Kone On Oct. 9, 2017, 1:03 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62836/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 1:03 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8051 > https://issues.apache.org/jira/browse/MESOS-8051 > > > Repository: mesos > > > Description > ------- > > When the scheduler tries to kill multiple tasks in the task group > simultaneously, the default executor will kill the tasks one by > one. When the first task is killed, the default executor will kill > all the other tasks in the task group, however, we need to ignore > the tasks which are already being killed, otherwise, the check > `CHECK(!container->killing);` in `DefaultExecutor::kill()` will fail. > > > Diffs > ----- > > src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 > > > Diff: https://reviews.apache.org/r/62836/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >