> On Oct. 4, 2017, 9:26 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/open.hpp > > Lines 26 (patched) > > <https://reviews.apache.org/r/62638/diff/3/?file=1839275#file1839275line26> > > > > I believe we should update the minimal Linux kernel requirements in the > > getting started documentation, > > https://github.com/apache/mesos/blob/32ea75b8426fb3972680a397dc3a05ff266d166d/docs/getting-started.md#L27. > > > > With this change we are introducing a hard requirement on kernels > > >=2.6.23 for even basic functionality, see > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f23513e8d96cf5e6cf8d2ff0cb5dd6bbc33995e4, > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4a19542e5f694cd408a32c3d9dc593ba9366e2d7.
Updated the docs in [r/62939](https://reviews.apache.org/r/62939/). - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review187074 ----------------------------------------------------------- On Sept. 27, 2017, 10:20 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62638/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 10:20 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu. > > > Bugs: MESOS-8027 > https://issues.apache.org/jira/browse/MESOS-8027 > > > Repository: mesos > > > Description > ------- > > The `O_CLOEXEC` fallback code was broken since it did not guarantee > to include `fcntl.h` before checking for the `O_CLOEXEC` symbol. > O_CLOEXEC is supported by all reasonably current service platforms, > so we should not need to fall back to compatibility code. So rather > than fixing the fallback code, we can just eliminate it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/open.hpp > c9346c62e01688f0f55811f7acbe63321b084355 > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > ac90bf08ccf5b594e70310e9843475502b3603a5 > 3rdparty/stout/include/stout/windows.hpp > fd7ffeabd2f33c45dcd67f1f54db7671a89dac64 > > > Diff: https://reviews.apache.org/r/62638/diff/4/ > > > Testing > ------- > > make check (Fedora 26) > > Manually verified that sandbox files opened through the webui get the > `O_CLOEXEC` flag applied. > > > Thanks, > > James Peach > >
