----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/#review188183 -----------------------------------------------------------
Fix it, then Ship it! src/slave/paths.hpp Lines 59 (patched) <https://reviews.apache.org/r/63018/#comment265422> It would be nice to call out what will be stored under this directory. For instance, csi endpoint, and volume bind mounts. src/slave/paths.hpp Lines 84-85 (patched) <https://reviews.apache.org/r/63018/#comment265217> A single `state` file because operations and resources have to be checkpointed atomically. - Jie Yu On Oct. 16, 2017, 6:25 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63018/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:25 p.m.) > > > Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8097 > https://issues.apache.org/jira/browse/MESOS-8097 > > > Repository: mesos > > > Description > ------- > > A local resource provide can use > `work_dir/resource_providers/<type>/<name>/<id>` to store whatever data > whose lifecycle is not tied to the agent ID, and store checkpoints, > whose lifecycles should be tied to the agent ID, under > `work_dir/meta/slaves/latest/resource_providers/<type>/<name>/<id>`. > > > Diffs > ----- > > src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed > src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f > src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da > src/resource_provider/storage/provider.hpp > 6de88c2329b358fcf48bc39ddda0132170991c3c > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 > src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 > > > Diff: https://reviews.apache.org/r/63018/diff/1/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
