----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188433 -----------------------------------------------------------
src/launcher/fetcher.cpp Lines 192-211 (original), 198-209 (patched) <https://reviews.apache.org/r/60628/#comment265427> I've mentioned this a few times, but this function at least appears super redundant. It's only used in the fetcher's `download()` and `fetchFromCache()`. It's true that these are dumb and expect `Try<string> copy(a, b)` where the result is always `b` (or the error), and I just wish we could fix the use of it instead. Maybe at least leave a `// TODO: Refactor code to eliminate redundnant function.` Since it looks so funny to have `copyFile` return `copyfile`. src/launcher/fetcher.cpp Lines 267-272 (original), 265-273 (patched) <https://reviews.apache.org/r/60628/#comment265428> I've mentioned in other reviews, but we _do know_ how to handle `chmod +x` for Windows: we explicitly don't do anything. I don't think this is a `TODO` but a `NOTE: Windows does not have the concept of executable permissions.` It's handled instead by file extensions (and a list in the registrary that says which extensions are "executable"). Correct me if I'm wrong, but I don't think we'll _ever_ do anything other than not execute this code on Windows. src/launcher/fetcher.cpp Lines 482-489 (original), 483-494 (patched) <https://reviews.apache.org/r/60628/#comment265429> This one is `chown`, not `chmod`, and really more of a revisit of MESOS-4310 (and MESOS-8063). It is possible to impersonate a user on Windows, so we probably should open a new issue to implement `chown` and then `runas` like code-paths. src/tests/fetcher_tests.cpp Line 531 (original), 535 (patched) <https://reviews.apache.org/r/60628/#comment265431> Glad this worked out :) src/tests/fetcher_tests.cpp Lines 925 (patched) <https://reviews.apache.org/r/60628/#comment265430> Nit: s/doesns't/doesn't/ - Andrew Schwartzmeyer On Oct. 16, 2017, 6:19 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60628/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:19 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Tests for tar, gzip, and such won't be working on Windows for > the time being. Thoughts are to provide this capability to the > Fetcher in a cross-platform manner via a programmatic code library > rather than Linux-specific command line tools (tar, gzip, etc). > See MESOS-8064 for more details. > > In the short term, zip and unzip will work since PowerShell can > support that natively. > > > Diffs > ----- > > src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b > src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d > src/slave/containerizer/fetcher.cpp > ba5b0979aa427c5b3dbacf39661d6027da13e0d6 > src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > > > Diff: https://reviews.apache.org/r/60628/diff/4/ > > > Testing > ------- > > See upstream. > > > Thanks, > > Jeff Coffler > >
