----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review188445 -----------------------------------------------------------
include/mesos/agent/agent.proto Lines 437-440 (patched) <https://reviews.apache.org/r/60890/#comment265441> You need a rebase. jpeach recently added some new fields for `WaitNestedContainer`. If you want to deprecate `WAIT_NESTED_CONTAINER`, you'll have to make sure it has feature parity. - Jie Yu On Oct. 16, 2017, 11:41 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60890/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 11:41 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Launching a standalone container is very similar to launching a > nested container, except that the caller must specify some Resources. > As such, this patch deprecates some nested container APIs > and replaces them with more generically named APIs. > > This applies to the Launch, Wait, Kill, and Remove > (nested) container APIs. > > > Diffs > ----- > > include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 > include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f > > > Diff: https://reviews.apache.org/r/60890/diff/4/ > > > Testing > ------- > > make > > See later patches in chain. > > > Thanks, > > Joseph Wu > >
