> On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 38 (patched) > > <https://reviews.apache.org/r/60621/diff/4/?file=1858855#file1858855line38> > > > > nit: whitespace
Removed blank line. > On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 45-50 (patched) > > <https://reviews.apache.org/r/60621/diff/4/?file=1858855#file1858855line45> > > > > nit: indentation Emacs default, sorry. Fixed. > On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 37 (patched) > > <https://reviews.apache.org/r/60621/diff/4/?file=1858856#file1858856line37> > > > > nit: whitespace Fixed. > On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 51-55 (patched) > > <https://reviews.apache.org/r/60621/diff/4/?file=1858856#file1858856line51> > > > > nit: indentation Fixed. > On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/tests/os/copyfile_tests.cpp > > Lines 79 (patched) > > <https://reviews.apache.org/r/60621/diff/4/?file=1858858#file1858858line79> > > > > nit: indentation Fixed. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review188413 ----------------------------------------------------------- On Oct. 17, 2017, 1:16 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60621/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 1:16 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > The os::copyfile() method provides an API to copy a file from one > location to another. Note that copying of directories are not > supported, and that the destination directory must exist before a > file can be copied into a directory. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/os/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/copyfile.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/os/copyfile_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60621/diff/4/ > > > Testing > ------- > > See upstream > > Note that Joe made some changes to this, I ended up taking his changes as is. > > > Thanks, > > Jeff Coffler > >
