> On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > Needs a description still.
Ok. > On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > src/hdfs/hdfs.cpp > > Lines 125-134 (patched) > > <https://reviews.apache.org/r/60626/diff/4/?file=1858873#file1858873line125> > > > > nit: Maybe it's just me, but this could just be `Option<int> status` > > and then `status.get()` below; that's _usually_ how it's done in the > > codebase. Could have. But I don't like the idea of resolving get() multiple times. Six of one, dozen of another. I'll leave this one to Joe to change if he wants. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review188428 ----------------------------------------------------------- On Oct. 17, 2017, 1:19 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60626/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 1:19 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Eliminated os::shell calls from HDFS for Windows compatibility. > > > Diffs > ----- > > src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4 > > > Diff: https://reviews.apache.org/r/60626/diff/4/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
