----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/#review188771 -----------------------------------------------------------
Ship it! Made some minor tweaks to the comments and added some TODOs, looks good! - Benjamin Mahler On Oct. 19, 2017, 4:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62911/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 4:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, > and Jason Lai. > > > Bugs: MESOS-8075 > https://issues.apache.org/jira/browse/MESOS-8075 > > > Repository: mesos > > > Description > ------- > > The `ReadWriteLock` class is similar to `Mutex`, but allows extra concurrency > if > some actions can be performed concurrently safely while certain actions > require full mutual exclusive. > > This implementation guarantees starvation free for `write_lock()` by queuing > up > `read_lock()` when some `write_lock()` is already in queue. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 94c7a722aab6c36174f117f0b6239cb988e476a9 > 3rdparty/libprocess/include/process/rwlock.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/62911/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
