----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63332/#review189323 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/sorter/drf/sorter.hpp Lines 385-386 (original), 388-392 (patched) <https://reviews.apache.org/r/63332/#comment266335> Not yours, but can we use ``` CHECK(resources.contains(slaveId)); CHECK(resources.at(slaveId).contains(oldAllocation)) << ... ``` like above? It doesn't strictly belong to this review but since you are editing these lines we might as well. - Jiang Yan Xu On Oct. 26, 2017, 9:42 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63332/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 9:42 a.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > If calls to these checks fails, log related resources objects which > causes the failure. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > 77e52dec735d276389643f7f356cd763b2f785e9 > > > Diff: https://reviews.apache.org/r/63332/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
