> On Oct. 26, 2017, 7:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1113-1120 (original), 1152-1164 (patched) > > <https://reviews.apache.org/r/55334/diff/11/?file=1863851#file1863851line1152> > > > > After looking at the slave code. it seems to me we can remove the whole > > part and the TODO. > > > > Not yours. this was from a tech debt when we combined the launch() > > method > > https://github.com/apache/mesos/commit/17ffb97ae7eda78edf85b204eba35bc59649a479
Are you suggesting that a nested container's config does not need `executor_info` anymore? - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review188981 ----------------------------------------------------------- On Oct. 20, 2017, 4:41 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55334/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 4:41 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > This patch includes the following change: > - Checkpointed `ContainerConfig` used to launch a container; > - Added helper function to read checkpointed `ContainerConfig`; > - Recovered `ContainerConfig`. > - Make `ContainerConfig` Option in `Container` struct to indicate whether > recovered. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b > src/slave/containerizer/mesos/containerizer.cpp > 78fdd21f8b7ede4beedff31ba2b488ffebd4ea31 > src/slave/containerizer/mesos/paths.hpp > a03f15e01e8eb8a1326baad8d7db96a79d785482 > src/slave/containerizer/mesos/paths.cpp > 0c61c20c345a327ec469b382558aaeed0280e754 > > > Diff: https://reviews.apache.org/r/55334/diff/11/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
