----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63322/#review189628 -----------------------------------------------------------
Patch looks great! Reviews applied: [63001, 62903, 63094, 63321, 63322] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 30, 2017, 5:04 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63322/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 5:04 p.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-8130 > https://issues.apache.org/jira/browse/MESOS-8130 > > > Repository: mesos > > > Description > ------- > > This patch adds empty placeholder handler functions which will > be used for offer operation status updates as well as their > acknowledgement and reconciliation. > > A number of switch statements are also updated to handle new > enum values and validation code is added. > > > Diffs > ----- > > src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853 > src/examples/long_lived_framework.cpp > adfe10eca2af26e8294171256e5f053fb46abf24 > src/examples/test_http_framework.cpp > e640800055bd9a946663de377970e867d29c750a > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp > 0e7716d489556ef58313cb5f95c39234aea82f11 > src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043 > src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 > src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 > src/master/validation.cpp d6d6f21b4cb2146d04e03b722f71230b6f0f600e > src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de > src/slave/slave.hpp 1b7f61671a1cf8f516d28c3bda516478f1213594 > src/slave/slave.cpp 817dca4fc3e1028ccc13b8a1bb1ee783afb77166 > src/tests/mesos.hpp 615e4ce19b51bb7284feef8edf6fd2b1753c9bb0 > > > Diff: https://reviews.apache.org/r/63322/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
