----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63420/#review189646 -----------------------------------------------------------
Patch looks great! Reviews applied: [63420] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 30, 2017, 5:27 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63420/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 5:27 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Moved the Linux namespace helper implementations from the header file > to the source file. This has a (theoretical) improvement to compilation > times, and also improves encapsulation and reduces header pollution for > consumers of these APIs. > > > Diffs > ----- > > src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31 > src/linux/ns.hpp 3d3a1fb6d0e3fffc4ff56625a76fb749a7afe51b > src/linux/ns.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > 927d95be2c25ceb324acac99edaee24a28a5d59c > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 8675640e0a4addc706bc2eabfe2fe4f08e19231e > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > fc68f04b42f12a59518a2eea43e5bd49787d4646 > src/slave/containerizer/mesos/isolators/volume/secret.cpp > ee9366fc360575570185ed8f69eb579006739380 > > > Diff: https://reviews.apache.org/r/63420/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
