----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ -----------------------------------------------------------
(Updated Oct. 30, 2017, 11:59 p.m.) Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Changes ------- Clean up and comment fixes. Bugs: MESOS-4945 https://issues.apache.org/jira/browse/MESOS-4945 Repository: mesos Description ------- This includes the following changes: - add a `pruneImages()` function on the chain of relevant classes; - implement prune in docker store; - fix mock interface to keep existing tests pass. Diffs (updated) ----- src/slave/containerizer/composing.hpp 06d68eef5de7745e32f0e808f11016bcc285dd8f src/slave/containerizer/composing.cpp 587f009384f0c7ef87482686578dc822d3d5b208 src/slave/containerizer/containerizer.hpp 449bb5d0902936faae7bf9bae9c703b219aed842 src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270 src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 src/slave/containerizer/mesos/containerizer.hpp 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b src/slave/containerizer/mesos/containerizer.cpp 100e3bbda543d87808da9ff6bea42da5099ea8c5 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0 src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095 src/slave/containerizer/mesos/provisioner/provisioner.hpp 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b src/slave/containerizer/mesos/provisioner/store.hpp 01ab83dca79e51b8c96d18ee65705912b0ac8324 src/slave/containerizer/mesos/provisioner/store.cpp cc5cc81e05f29bb0e11ffa13cdb8d63d4397114f src/tests/containerizer.hpp a778b8581904bacea9eec3ff50c3c009959b5dac src/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a src/tests/containerizer/mock_containerizer.hpp 0adcb01e6c12d6cc4abed1f14fa2df833ffc6569 Diff: https://reviews.apache.org/r/56721/diff/14/ Changes: https://reviews.apache.org/r/56721/diff/13-14/ Testing ------- Thanks, Zhitao Li