----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review189678 -----------------------------------------------------------
src/master/flags.cpp Lines 630-635 (patched) <https://reviews.apache.org/r/63370/#comment266886> This looks like a boolean flag, any reason you decided to use a string? It would be nice to keep our boolean enable/disable style flags consistent. - Benjamin Mahler On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63370/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:04 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > This flag allows explicit disabling of the memory profiler > endpoint in the master and agent binaries. > > > Diffs > ----- > > src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec > src/master/flags.cpp 18f405b7e9cc6bd0011284b631974eee52dd2bf3 > src/master/main.cpp f65ce637d77ce183f83b70dce6da8d0b4b8b8e71 > src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba > src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807 > src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 > > > Diff: https://reviews.apache.org/r/63370/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >