----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63476/#review189885 -----------------------------------------------------------
Patch looks great! Reviews applied: [63476] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 2, 2017, 5:04 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63476/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 5:04 a.m.) > > > Review request for mesos, Qian Zhang and Vinod Kone. > > > Bugs: MESOS-8157 > https://issues.apache.org/jira/browse/MESOS-8157 > > > Repository: mesos > > > Description > ------- > > This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899. > > The commit being reverted introduced a build break on Windows. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 21950f57e9eae741ac219d930fe9c4fc94d4f47f > src/tests/kill_policy_test_helper.cpp > 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d > > > Diff: https://reviews.apache.org/r/63476/diff/1/ > > > Testing > ------- > > Successfully built on Windows after failing to build before the revert. > > > Thanks, > > Andrew Schwartzmeyer > >