> On Nov. 2, 2017, 4:48 p.m., Benjamin Mahler wrote: > > docs/isolators/windows.md > > Lines 8 (patched) > > <https://reviews.apache.org/r/63278/diff/1/?file=1869654#file1869654line8> > > > > Hm.. why is it called cpuset? That word comes from the cgroup subsystem > > that lets you restrict which cores can be used by a cgroup, but the windows > > mechanisms don't sound the same at all? > > > > Would just `windows/cpu` be more appropriate? > > Andrew Schwartzmeyer wrote: > Jie and Joe argued for `cpuset` because it's a hard cap, and so more like > cgroup's `cpuset` than just the `cpu` isolator. > > But if in fact `cpuset` means: > > that lets you restrict which cores can be used by a cgroup > > Then yeah, this should be `cpu`. > > Joseph Wu wrote: > Since `cpuset` is not the correct term here (even though the semantics > are closer), let's go with `cpu`. But can you add a note in the docs that > explicitly calls out the difference between this hard cap and the cgroups > soft cap? (More explicit than the existing mention of a hard cap.)
Can do! - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review189992 ----------------------------------------------------------- On Nov. 2, 2017, 1:40 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63278/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 1:40 p.m.) > > > Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John > Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6690 > https://issues.apache.org/jira/browse/MESOS-6690 > > > Repository: mesos > > > Description > ------- > > This adds documentation on the usage of the job object isolators, which > enable task limits, as well as the statistics they report. > > > Diffs > ----- > > docs/isolators/windows.md PRE-CREATION > docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d > > > Diff: https://reviews.apache.org/r/63278/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
