> On Nov. 7, 2017, 6:40 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 8679-8681 (patched) > > <https://reviews.apache.org/r/63496/diff/6/?file=1883730#file1883730line8679> > > > > Would be good if this test or another could verify that a new resource > > version is sent for an RP after the RP makes an UPDATE_STATE call. > > Jie Yu wrote: > +1 > > maybe a TODO or a ticket for now. Let's note down all the tests we'll > need to write.
We'll only trigger a version change if an operation failed. https://reviews.apache.org/r/63625/ implements a test for a successful operation; I created https://issues.apache.org/jira/browse/MESOS-8181 to track adding tests for this. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190338 ----------------------------------------------------------- On Nov. 7, 2017, 11:01 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63496/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 11:01 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch introduces separate tests for clock values communicated > from resource providers and from agents to masters. > > > Diffs > ----- > > src/tests/slave_tests.cpp f9c2e6b41bdbc54ee0d8d06a2a41c92b7a1156cc > > > Diff: https://reviews.apache.org/r/63496/diff/7/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
