----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190593 -----------------------------------------------------------
Ship it! support/mesos-style.py Lines 99-111 (patched) <https://reviews.apache.org/r/62214/#comment268081> We should make sure to change the python linter to use this in a subsequent commit. - Kevin Klues On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62214/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 9:23 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > ------- > > The linter runs when changes on a JavaScript file are being committed. > We use ESLint with a configuration based on our current JS code base. > The linter and its dependencies (i.e. Node.js) are installed in a > virtual environment using Virtualenv and then Nodeenv. > > > Diffs > ----- > > support/.eslintrc.js PRE-CREATION > support/build-virtualenv PRE-CREATION > support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c > support/pip-requirements.txt PRE-CREATION > > > Diff: https://reviews.apache.org/r/62214/diff/8/ > > > Testing > ------- > > ``` > $ make check > ``` > > Following this commit, I have also tried to commit a change on a JavaScript > file and checked that ESLinter was correctly running. > > > Thanks, > > Armand Grillet > >
