----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63694/#review190601 -----------------------------------------------------------
src/slave/http.cpp Lines 2353-2354 (patched) <https://reviews.apache.org/r/63694/#comment268086> IIRC we do not say "ID", just "container. src/slave/http.cpp Lines 2490-2492 (patched) <https://reviews.apache.org/r/63694/#comment268088> Same comment here regarding ID. Also, please be consistent: either capture a reference and use it here or use `call.` above. src/slave/http.cpp Line 2750 (original), 2793 (patched) <https://reviews.apache.org/r/63694/#comment268090> This check is actually weird. {{ContainerID}} is optional in {{AttachContainerInput}} protobuf. Could you please contact the author and check whether we should make the field required or remove the check? Or maybe there is some validation before? src/slave/http.cpp Lines 2878-2879 (patched) <https://reviews.apache.org/r/63694/#comment268089> Please leading space instead of a trailing one. - Alexander Rukletsov On Nov. 9, 2017, 9:50 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63694/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 9:50 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-7361 > https://issues.apache.org/jira/browse/MESOS-7361 > > > Repository: mesos > > > Description > ------- > > This adds information such as the container ID when processing calls > regarding nested containers, the level when setting a new logging > level, and the path when processing calls regarding files. > > > Diffs > ----- > > src/slave/http.cpp cfae9979e58bca1864551bf16b741d6bae6602f8 > > > Diff: https://reviews.apache.org/r/63694/diff/2/ > > > Testing > ------- > > ``` > $ make check > ``` > > > Thanks, > > Armand Grillet > >
