-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63276/
-----------------------------------------------------------
(Updated Nov. 13, 2017, 5:57 p.m.)
Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John
Kordich, Joseph Wu, Li Li, and Michael Park.
Changes
-------
Refactored based on Jie's comments.
Bugs: MESOS-5462 and MESOS-6690
https://issues.apache.org/jira/browse/MESOS-5462
https://issues.apache.org/jira/browse/MESOS-6690
Repository: mesos
Description (updated)
-------
Instead of deriving from the POSIX isolators, we now have two real
Windows isolators that can be used together or separately. The `Cpu`
isolator enables a hard-cap CPU limit, and the `Mem` isolator enables a
hard-cap memory limit on the job object for the container.
These classes are separate derivations of `MesosIsolatorProcess`,
because introducing a `WindowsIsolatorProcess` base class would be
abstraction for the sole purpose of code deduplication.
Diffs (updated)
-----
src/CMakeLists.txt b0e223121f24ac0dc604dc2c639158b817eec535
src/Makefile.am 955f01a665019d7750980ff16f126ad63b524594
src/slave/containerizer/mesos/containerizer.cpp
100e3bbda543d87808da9ff6bea42da5099ea8c5
src/slave/containerizer/mesos/isolators/windows.hpp
b0621a5fc411b8812722f7fcf6580ed64dac5382
src/slave/containerizer/mesos/isolators/windows/cpu.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/windows/cpu.cpp PRE-CREATION
src/slave/containerizer/mesos/isolators/windows/mem.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/windows/mem.cpp PRE-CREATION
src/slave/flags.cpp 0eeecdc6023443a99c8e8fe29c2f7bf791c0a36e
Diff: https://reviews.apache.org/r/63276/diff/3/
Changes: https://reviews.apache.org/r/63276/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
