----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/ -----------------------------------------------------------
Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description ------- By removing the explicit system environment override code, and instead setting the system environment as the default in the `CreateProcess` wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled. Note that this also required fixing `os::host_default_path()` and using it, because the test used `PATH = /bin`, which breaks on Windows. Diffs ----- src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae src/tests/slave_tests.cpp 61dd940e4452a1dbc6c0361bfc917bdc2dd16be8 Diff: https://reviews.apache.org/r/63816/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer