----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63677/#review191052 -----------------------------------------------------------
Ship it! Ship It! - Andrei Budnik On Nov. 14, 2017, 7:11 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63677/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 7:11 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8159 > https://issues.apache.org/jira/browse/MESOS-8159 > > > Repository: mesos > > > Description > ------- > > If `os:Stack` is allocated with `mmap`, this automatically > guarantees the correct alignment (since `mmap` is page-aligned > by definition). > > Although `mmap` is not required to be async signal safe > (i.e. it might not be safe to call from a signal handler), in > practice it should be safe to call between `fork` and `exec` > since it is a raw system call that does not require any user > space locks to be held. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/linux.hpp > 68b4090aa5e6f23609c487128d91301755ae0e46 > > > Diff: https://reviews.apache.org/r/63677/diff/3/ > > > Testing > ------- > > sudo make check (Fedora 26) > > > Thanks, > > James Peach > >
