> On Nov. 15, 2017, 12:38 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 178 (patched) > > <https://reviews.apache.org/r/63810/diff/1/?file=1892184#file1892184line179> > > > > I've seen this function "stringify" before, but I don't have any > > context about it. Does it convert from wide string to UTF-8? Do we need to > > worry about non-ascii paths?
It's [right here](https://github.com/apache/mesos/blob/0eec1f39a60d75547b1ca714f193df0bda7beb7a/3rdparty/stout/include/stout/stringify.hpp#L59), it converts UTF-16 to UTF-8. Non-ASCII is therefore handled (to the extent that the rest of Mesos handles them). - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/#review191094 ----------------------------------------------------------- On Nov. 14, 2017, 3:14 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63810/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 3:14 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6735 > https://issues.apache.org/jira/browse/MESOS-6735 > > > Repository: mesos > > > Description > ------- > > This explicitly does not check for existence, nor does it follow > symlinks. It simply normalizes a given path to an absolute path. This > removes the `reparsepoint.hpp` and `symlink.hpp` dependency os > `os::realpath`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > e3d04480cf793482d958ea9571d96a29b6bf09b1 > 3rdparty/stout/include/stout/internal/windows/symlink.hpp > b9cf1229ec0b6c70fe9b9d358e867e91e475dfaa > 3rdparty/stout/include/stout/windows/fs.hpp > d7b883ca1f3f8972e1bf9fbd211cc564c7c30f14 > > > Diff: https://reviews.apache.org/r/63810/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
