> On Nov. 15, 2017, 12:53 p.m., John Kordich wrote: > > Nice fix, that would have been annoying otherwise.
Indeed, and we need to follow it up with properly propogating `GLOG_v`. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63815/#review191099 ----------------------------------------------------------- On Nov. 14, 2017, 3:16 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63815/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 3:16 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6816 > https://issues.apache.org/jira/browse/MESOS-6816 > > > Repository: mesos > > > Description > ------- > > Legacy code had caused the system environment to explicitly override the > supplied environment, but this is incorrect. The system environment > should be the default, with any supplied environment variables > overriding those. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/shell.hpp > 5c711837a3adbc89ad8793666e68eff7102566b3 > > > Diff: https://reviews.apache.org/r/63815/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
