> On Nov. 16, 2017, 8:49 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Line 830 (original), 831-833 (patched) > > <https://reviews.apache.org/r/63796/diff/1/?file=1891627#file1891627line831> > > > > This looks terrible, I wonder on which systems this will break... > > Reading > > http://tech.bluesmoon.info/2011/12/using-curl-with-ipv6-addresses.html , we > > probably need to wrap url into double quotes. Can you please also leave a > > comment saying why we do these magic movements?
Yes, I have updated the patch by adding a comment to explain it. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/#review191128 ----------------------------------------------------------- On Nov. 16, 2017, 3:22 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63796/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 3:22 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `CheckerProcess` support IPv6 for HTTP/TCP check. > > > Diffs > ----- > > src/checks/checker_process.cpp 7985e8d4dc6115f81a4daef0ce4eee67f4233c9f > > > Diff: https://reviews.apache.org/r/63796/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
