----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review191280 -----------------------------------------------------------
src/tests/containerizer/mesos_containerizer_tests.cpp Lines 103-121 (patched) <https://reviews.apache.org/r/55335/#comment269042> why change it back? a mistake? - Gilbert Song On Nov. 10, 2017, 11:31 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55335/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 11:31 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > These tests were using a `TaskInfo` field which is missing required > protobuf fields. After the previous patch begins to checkpoint > `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed, > thus caused these tests to fail. > > This patch backfills these fields to make these tests pass. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > ef424150183c782551a3019afcd4b9d1eb94b863 > > > Diff: https://reviews.apache.org/r/55335/diff/8/ > > > Testing > ------- > > GTEST_FILTER="MesosContainerizer*" make check > > > Thanks, > > Zhitao Li > >
