----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972 https://issues.apache.org/jira/browse/MESOS-6972 Repository: mesos Description ------- Tasks can be moved into master's internal data structures from message to save some cycles on copying the data. Diffs ----- src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f Diff: https://reviews.apache.org/r/63915/diff/1/ Testing ------- make check Ran benchmark with `--enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --enable-last-in-first-out-fixed-size-semaphore` `./mesos-tests.sh --benchmark --gtest_filter=AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.*` On 2608c0b8f62a9359d3d23e1724b6e91f316cfc76 (includes protobuf-3.5.0): ``` [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 Starting reregistration for all agents Reregistered 2000 agents with a total of 100000 running tasks and 100000 completed tasks in 16.202206916secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 (30065 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 Starting reregistration for all agents Reregistered 2000 agents with a total of 200000 running tasks and 0 completed tasks in 30.509804836secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 (57145 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 Starting reregistration for all agents Reregistered 20000 agents with a total of 100000 running tasks and 0 completed tasks in 22.581999748secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 (39629 ms) ``` On this chain of patches: ``` [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 Starting reregistration for all agents Reregistered 2000 agents with a total of 100000 running tasks and 100000 completed tasks in 8.456615936secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0 (22659 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 Starting reregistration for all agents Reregistered 2000 agents with a total of 200000 running tasks and 0 completed tasks in 15.09102354secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1 (43828 ms) [ RUN ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 Starting reregistration for all agents Reregistered 20000 agents with a total of 100000 running tasks and 0 completed tasks in 16.122729767secs [ OK ] AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2 (33182 ms) ``` Thanks, Dmitry Zhuk