----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63897/#review191275 -----------------------------------------------------------
src/master/master.hpp Lines 171 (patched) <https://reviews.apache.org/r/63897/#comment269008> - just call it `update()`- - Change to void and have another function that checks if a change is necessary src/master/master.hpp Lines 623 (patched) <https://reviews.apache.org/r/63897/#comment269009> registryUpdated -> updated src/master/master.hpp Lines 1049 (patched) <https://reviews.apache.org/r/63897/#comment269010> - rename to updateSlave() - Change bool in accordance with the changes to the funciton in Slave src/master/master.hpp Lines 1053 (patched) <https://reviews.apache.org/r/63897/#comment269011> agentCapabilities -> capabilities src/master/master.hpp Lines 2153 (patched) <https://reviews.apache.org/r/63897/#comment269015> Look into moving operations to separate header src/master/master.hpp Lines 2155 (patched) <https://reviews.apache.org/r/63897/#comment269012> UpdateSlaveConfiguration -> UpdateSlave src/master/master.hpp Lines 2173 (patched) <https://reviews.apache.org/r/63897/#comment269016> Maybe check if slaveInfo is actually changed. src/master/master.hpp Lines 2178 (patched) <https://reviews.apache.org/r/63897/#comment269013> slave -> agent src/master/master.cpp Line 6082 (original), 6086 (patched) <https://reviews.apache.org/r/63897/#comment269021> slave id -> slave info Think about solutions to this: - i.e. send a UUID in the Re[re]gisterSlave message and have the master return it src/master/master.cpp Lines 6087 (patched) <https://reviews.apache.org/r/63897/#comment269017> Add period. src/master/master.cpp Lines 6151 (patched) <https://reviews.apache.org/r/63897/#comment269022> Move this function src/master/master.cpp Lines 6176 (patched) <https://reviews.apache.org/r/63897/#comment269041> Rescind offers here if we don't already do it. src/master/master.cpp Line 6253 (original), 6303 (patched) <https://reviews.apache.org/r/63897/#comment269025> still marked -> already marked src/master/master.cpp Line 6288 (original), 6338 (patched) <https://reviews.apache.org/r/63897/#comment269028> Think about calling this failoverSlave() and moving the pid-relinking inside src/master/master.cpp Line 6296 (original), 6342 (patched) <https://reviews.apache.org/r/63897/#comment269030> Do this after the registry operation (and maybe also the in-memory slave update) src/master/master.cpp Line 6391 (original), 6453 (patched) <https://reviews.apache.org/r/63897/#comment269039> Reinstate this check and figure out why it was commented out in the first place. src/master/master.cpp Lines 6699 (patched) <https://reviews.apache.org/r/63897/#comment269040> Join this function with ___reregisterSlave - Benno Evers On Nov. 17, 2017, 12:19 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63897/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 12:19 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > WIP. Add prototype of master changes. > > > Diffs > ----- > > include/mesos/mesos.proto 859fdff4d9a0604bc506b08af79075084ae23466 > include/mesos/v1/mesos.proto cfd4abd3af1d8c9fbd31659161eada9ec9f92282 > src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31 > src/master/constants.hpp 725680b1e5f1fb9ca87ec5130d0eff72309432ae > src/master/constants.cpp PRE-CREATION > src/master/detector/standalone.hpp bbe3ce9b05fa3c321988e25a305507e22b938e4c > src/master/detector/zookeeper.hpp 5d0435ee3863e43a999a90595eaa006bbdfdc449 > src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043 > src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac > src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006 > src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 > > > Diff: https://reviews.apache.org/r/63897/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
