----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191375 -----------------------------------------------------------
src/tests/health_check_tests.cpp Lines 1972 (patched) <https://reviews.apache.org/r/63910/#comment269159> What is `local mode`? :) src/tests/health_check_tests.cpp Lines 2040 (patched) <https://reviews.apache.org/r/63910/#comment269160> Feels like we should have a helper function for this, similar to `createTask`? src/tests/health_check_tests.cpp Line 2043 (original), 2050 (patched) <https://reviews.apache.org/r/63910/#comment269161> why s/->/get()? src/tests/health_check_tests.cpp Line 2062 (original), 2070 (patched) <https://reviews.apache.org/r/63910/#comment269162> Not yours but s/mesos/Mesos src/tests/health_check_tests.cpp Line 2080 (original), 2077 (patched) <https://reviews.apache.org/r/63910/#comment269163> s/CMD/command src/tests/health_check_tests.cpp Line 2268 (original), 2308 (patched) <https://reviews.apache.org/r/63910/#comment269164> This test is a user network test, so we technically don't need to do this. We could set the port statically since the container is going to get its own network namespace. src/tests/health_check_tests.cpp Line 2272 (original), 2312 (patched) <https://reviews.apache.org/r/63910/#comment269165> Just a thought: Can we just use `nginx:alpine` image? We won't need to rely on `nc` to do this stuff. It would work cleanly since the container is on its network namespace. src/tests/health_check_tests.cpp Lines 2450 (patched) <https://reviews.apache.org/r/63910/#comment269166> We should try and see if we can publish this image to :https://hub.docker.com/u/mesos/ Also, I assuming this a custorm image. We should commit the `Dockerfile` for this image to our test repo. More importantly want to the cert being used in this test to be part of the repo. src/tests/health_check_tests.cpp Lines 2525 (patched) <https://reviews.apache.org/r/63910/#comment269167> As you mentioned, given that this test is identical to the HTTP test above, can we just parameterize the `HealthCheck.type` field as well in the above test case? - Avinash sridharan On Nov. 17, 2017, 1:35 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63910/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 1:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Removed 3 tests which only run on IPv4 Docker network. > ROOT_DOCKER_DockerHealthyTaskViaHTTP > ROOT_DOCKER_DockerHealthyTaskViaHTTPS > ROOT_DOCKER_DockerHealthyTaskViaTCP > > Added 3 tests which run on both IPv4 and IPv6 Docker networks, so they > should cover the above 3 tests. > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTP > ROOT_DOCKER_USERNETWORK_HealthyTaskViaHTTPS > ROOT_DOCKER_USERNETWORK_HealthyTaskViaTCP > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 67945ddc4f98ffa072f584af8106967e7ff336d3 > src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 > src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb > > > Diff: https://reviews.apache.org/r/63910/diff/1/ > > > Testing > ------- > > Ran all newly added tests repeatedly (20 times), they all succeeded. > > > Thanks, > > Qian Zhang > >
