> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.hpp > > Lines 2475-2477 (patched) > > <https://reviews.apache.org/r/61473/diff/7/?file=1819741#file1819741line2478> > > > > Because this method takes a pointer, this mutation could affect future > > uses of it. Even though right now nothing that cares about the state > > follows the call of `addUnreachableTask`, it may still be good to not > > propagate the change. > > > > How about doing it in `addUnreachableTask`? > > > > ``` > > void addUnreachableTask(const Task& _task) > > { > > Task* task = new Task(_task); > > > > // We have to use TASK_LOST for non-partition-aware frameworks > > // for backwards compatibility. > > if (!capabilities.partitionAware) { > > task->set_state(TASK_LOST); > > } > > > > unreachableTasks.set(task.task_id(), process::Owned<Task>(task)); > > } > > ```
I think this comment is not applicable anymore since we are not changing the state but just passing a boolean around to move the tasks in the right data structure. - Megha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186615 ----------------------------------------------------------- On Nov. 17, 2017, 7:26 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61473/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 7:26 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7215 > https://issues.apache.org/jira/browse/MESOS-7215 > > > Repository: mesos > > > Description > ------- > > Master will not kill the tasks for non-Partition aware frameworks > when an unreachable agent re-registers with the master. > Master used to send a ShutdownFrameworkMessages to the agent > to kill the tasks from non partition aware frameworks including the > ones that are still registered which was problematic because the offer > from this agent could still go to the same framework which could then > launch new tasks. The agent would then receive tasks of the same > framework and ignore them because it thinks the framework is shutting > down. The framework is not shutting down of course, so from the master > and the scheduler's perspective the task is pending in STAGING forever > until the next agent reregistration, which could happen much later. > This commit fixes the problem by not shutting down the non-partition > aware frameworks on such an agent. > > > Diffs > ----- > > include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 > include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e > src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 > > > Diff: https://reviews.apache.org/r/61473/diff/15/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
