----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63999/#review191893 -----------------------------------------------------------
support/mesos-gtest-runner.py Lines 136 (patched) <https://reviews.apache.org/r/63999/#comment269831> Could you please add a comment explaining how does the flags passed on the command line have precedence over the defaults? - Armand Grillet On Nov. 21, 2017, 9:09 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63999/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 9:09 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > This patch modifies the parallel test runner to examine the > environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of > flags to pass. Flags given explicitly on the command line always have > precedence over default flags from the environment variable. > > This allows e.g., to set the default level of parallelism to not > overload systems with many CPUs during 'make check' (which could > ultimately lead to tests hitting timeouts). > > > Diffs > ----- > > support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6 > > > Diff: https://reviews.apache.org/r/63999/diff/1/ > > > Testing > ------- > > Verified manually that > > $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py > ./3rdparty/stout/tests/stout-tests > > executes 20 concurrent runs and that > > $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 > ./3rdparty/stout/tests/stout-tests > > executes 6 concurrent runs and that > > > Thanks, > > Benjamin Bannier > >
