----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ -----------------------------------------------------------
(Updated Nov. 27, 2017, 5:45 p.m.) Review request for mesos, Andrew Schwartzmeyer and John Kordich. Changes ------- Rebased + addressed feedback. I also changed the image to use the nanserver image instead since it is 50x smaller. However, the nanoserver image doesn't work properly with volume mounts in process isolation mode, so I changed the mount tests to use hyper-v isolation, which works fine. Summary (updated) ----------------- Windows: Ported docker_tests.cpp. Bugs: MESOS-7342 https://issues.apache.org/jira/browse/MESOS-7342 Repository: mesos Description (updated) ------- Ported the disabled tests to run on Windows. The following tests could not be ported due to Windows platform limitations and remain diabled: - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside sandbox). - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support). - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support). Diffs (updated) ----- src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d Diff: https://reviews.apache.org/r/63862/diff/2/ Changes: https://reviews.apache.org/r/63862/diff/1-2/ Testing (updated) ------- Windows mesos-test: [==========] 754 tests from 77 test cases ran. (270586 ms total) [ PASSED ] 754 tests. Windows DockerTest only: [==========] 11 tests from 1 test case ran. (85617 ms total) [ PASSED ] 11 tests. Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU): [==========] 12 tests from 1 test case ran. (12413 ms total) [ PASSED ] 12 tests. Thanks, Akash Gupta