----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64073/#review191948 -----------------------------------------------------------
3rdparty/libprocess/src/libevent_ssl_socket.cpp Line 958 (original), 959-960 (patched) <https://reviews.apache.org/r/64073/#comment269898> Can't we just make Queue::get discardable? Seems to have clear semantics. And would give us the benefit of returning a discarded future rather than convering to Failure as you've done? - Benjamin Mahler On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64073/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2017, 10:28 p.m.) > > > Review request for mesos, Alexander Rukletsov, Avinash sridharan, and > Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently there is no way to discard `LibeventSSLSocketImpl::accept()` > because `Queue::get()` isn't discardable. This patch uses an `await()` so > that we can discard. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 1c95ebabfefd07aaeb053b965ab8e4550dfccaef > > > Diff: https://reviews.apache.org/r/64073/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
