----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review191953 -----------------------------------------------------------
src/tests/registrar_tests.cpp Lines 270 (patched) <https://reviews.apache.org/r/64009/#comment269905> period at the end. src/common/protobuf_utils.hpp Lines 155 (patched) <https://reviews.apache.org/r/64009/#comment269903> can you confirm if already converted resources will result in a no-op? src/common/protobuf_utils.hpp Lines 157 (patched) <https://reviews.apache.org/r/64009/#comment269904> `isEqualPostReservationRefinement()` - Vinod Kone On Nov. 27, 2017, 11:29 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64009/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 11:29 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This operation can be used to update the stored state > of an existing, admitted slave. > > > Diffs > ----- > > src/common/protobuf_utils.hpp b2aa3654db2fe7d7d9d275ded81c6d54244654ee > src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc > src/master/registry_operations.hpp PRE-CREATION > src/master/registry_operations.cpp PRE-CREATION > src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 > > > Diff: https://reviews.apache.org/r/64009/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
