----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63812/#review191983 -----------------------------------------------------------
looks good. just small nit on spacing. 3rdparty/stout/include/stout/os/windows/realpath.hpp Lines 42 (patched) <https://reviews.apache.org/r/63812/#comment269986> 4 spaces right? 3rdparty/stout/include/stout/os/windows/realpath.hpp Line 44 (original), 54 (patched) <https://reviews.apache.org/r/63812/#comment269987> Same here - Akash Gupta On Nov. 14, 2017, 11:14 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63812/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 11:14 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6735 > https://issues.apache.org/jira/browse/MESOS-6735 > > > Repository: mesos > > > Description > ------- > > The existing implementation (1) did not resolve symlinks and (2) did not > check for existence of the path. This resulted in unexpected behaviors > by users of the function. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/realpath.hpp > 81a33bd2708c0871c4f23c12fdd29fc8d35682e3 > > > Diff: https://reviews.apache.org/r/63812/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
