----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review192183 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto Lines 1402 (patched) <https://reviews.apache.org/r/63971/#comment270225> please update v1 protobuf too. include/mesos/resource_provider/volume_profile.hpp Lines 86 (patched) <https://reviews.apache.org/r/63971/#comment270226> Should we change this to `csi::VolumeCapability`? - Jie Yu On Nov. 29, 2017, 10:34 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63971/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 10:34 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jie Yu. > > > Bugs: MESOS-8251 > https://issues.apache.org/jira/browse/MESOS-8251 > > > Repository: mesos > > > Description > ------- > > This module is currently intended for use by the Storage Local > Resource Provider (SLRP), but may be used by other components if > those components use any of the affected Container Storage Interface > (CSI) requests. The affected calls are listed in the module's comments. > > > Diffs > ----- > > include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 > include/mesos/resource_provider/volume_profile.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63971/diff/2/ > > > Testing > ------- > > None yet. This chain is currently incomplete. > > > Thanks, > > Joseph Wu > >
