> On Nov. 30, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote: > > src/tests/health_check_tests.cpp > > Lines 2491-2492 (original), 2491-2492 (patched) > > <https://reviews.apache.org/r/64104/diff/1/?file=1902190#file1902190line2491> > > > > This seems like it would be broken on other platforms if Docker isn't > > installed. I'll ping Jie and Joe and see if there's an existing issue. > > Akash Gupta wrote: > I don't think the DOCKER part is needed. It calls > `MesosContainerizer::create` to run a docker image (so universal container > mode), so there shouldn't be a dependency on docker.
Ah you're right! It uses a Docker image but explicitly does not use Docker (cause who wants Docker anyway?). - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192433 ----------------------------------------------------------- On Nov. 30, 2017, 9:18 a.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64104/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2017, 9:18 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, > and Joseph Wu. > > > Bugs: MESOS-6709 > https://issues.apache.org/jira/browse/MESOS-6709 > > > Repository: mesos > > > Description > ------- > > Added dependency of curl to agent. Enabled most health check tests. > > > Diffs > ----- > > src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 > src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 > > > Diff: https://reviews.apache.org/r/64104/diff/1/ > > > Testing > ------- > > There are two health check tests which are not enabled yet, because they > require the IOSwitchboard to be ported first. We can't resolve MESOS-6709 > quite yet until that is addressed. The rest of the tests pass on both > Linux/Windows, as mentioned in #64102 > > > Thanks, > > John Kordich > >
