----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64423/#review193150 -----------------------------------------------------------
src/master/master.cpp Lines 7200 (patched) <https://reviews.apache.org/r/64423/#comment271653> no need for this check if it's a required field src/master/master.cpp Lines 7207-7208 (patched) <https://reviews.apache.org/r/64423/#comment271654> Ditto. let's make it a required field src/master/master.cpp Lines 7204-7207 (original), 7223-7226 (patched) <https://reviews.apache.org/r/64423/#comment271659> This probably need some adjustment given that message.offer_operations will be for agent default resources and `slave->offerOperations` will be for all RPs? src/master/master.cpp Line 7306 (original), 7341 (patched) <https://reviews.apache.org/r/64423/#comment271663> i was expecting that message.offer_operations is only for agent default resources. Any resource provider resources should go to the corresponding resource provider struct.. src/slave/slave.cpp Lines 6800 (patched) <https://reviews.apache.org/r/64423/#comment271664> Let's use `previousOversubscribedResources` here to be more explicit src/slave/slave.cpp Lines 6850 (patched) <https://reviews.apache.org/r/64423/#comment271660> fix style issue - Jie Yu On Dec. 7, 2017, 5:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64423/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 5:49 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch changes the way resource-provider related information is > passed. Instead of aggregating all information from both the agent and > resource providers into global per-agent lists in > `UpdateSlaveMessage`, with this patch we pass resource-provider > related information explicitly. We can in a subsequent patch surface > this information in e.g., the operator API. > > > Diffs > ----- > > src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249 > src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0 > src/slave/slave.hpp fc762fb1e8aeb57b0d7ad551d960ec4be06e8e33 > src/slave/slave.cpp dd830d93f8a08720231e3d4a6421f7a058ba6093 > src/tests/slave_tests.cpp 25cfd4730c3d77d1886745204b13ca3cb140620c > > > Diff: https://reviews.apache.org/r/64423/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
