----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64472/#review193297 -----------------------------------------------------------
Fix it, then Ship it! src/status_update_manager/offer_operation.cpp Lines 38-40 (original), 38-41 (patched) <https://reviews.apache.org/r/64472/#comment271847> Indent two more spaces. src/status_update_manager/status_update_manager_process.hpp Line 112 (original), 112 (patched) <https://reviews.apache.org/r/64472/#comment271849> Let's make the process ID "offer-operation-status-update-manager". src/status_update_manager/status_update_manager_process.hpp Line 382 (original), 387 (patched) <https://reviews.apache.org/r/64472/#comment271850> Kind of strange that the logging above is INFO and this is WARNING. I feel like this should be LOG(INFO)? src/status_update_manager/status_update_manager_process.hpp Line 594 (original), 609 (patched) <https://reviews.apache.org/r/64472/#comment271956> Remove this period. src/status_update_manager/status_update_manager_process.hpp Line 916 (original), 934 (patched) <https://reviews.apache.org/r/64472/#comment271957> s/Failed to/Failed to write to file/ - Greg Mann On Dec. 9, 2017, 12:25 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64472/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2017, 12:25 a.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This patch adds to the log and error messages the type of status update > handled by the instance of `StatusUpdateManagerProcess`. > > > Diffs > ----- > > src/status_update_manager/offer_operation.cpp > f66690eadc0d7b16cc7de1b518904db2cab7ef82 > src/status_update_manager/status_update_manager_process.hpp > 1ac64410594134ce3e709d396d0a74a3d0aa2007 > > > Diff: https://reviews.apache.org/r/64472/diff/1/ > > > Testing > ------- > > `GLOG_v=1 bin/mesos-tests.sh > --gtest_filter="*OfferOperationStatusUpdateManagerTest*" --verbose` on > GNU/Linux > > > Thanks, > > Gaston Kleiman > >