----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/#review194084 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 897-912 (patched) <https://reviews.apache.org/r/64658/#comment272806> Looks like this is not needed to me? src/resource_provider/storage/provider.cpp Lines 1153 (patched) <https://reviews.apache.org/r/64658/#comment272809> what if `watch` failed? at least print some error message? src/resource_provider/storage/provider.cpp Lines 1250 (patched) <https://reviews.apache.org/r/64658/#comment272813> Looks like this function can be called in any state? src/resource_provider/storage/provider.cpp Lines 1266 (patched) <https://reviews.apache.org/r/64658/#comment272815> remove the extra space before `=` src/resource_provider/storage/provider.cpp Lines 2587-2588 (patched) <https://reviews.apache.org/r/64658/#comment272819> Maybe we need a helper here? `Result<string> getDiskProfile(const Resource& resource)` - Jie Yu On Dec. 18, 2017, 2:25 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64658/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 2:25 a.m.) > > > Review request for mesos, Jie Yu and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This changes the Storage Local Resource Provider's source of profile > information from only using the default to using a VolumeProfileAdaptor > module. > > This patch is based on https://reviews.apache.org/r/64616. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 158b6b408002209aa9a79a6772da30c984aad61a > > > Diff: https://reviews.apache.org/r/64658/diff/6/ > > > Testing > ------- > > See later in chain. This patch will fail SLRP tests. They are fixed in a > followup patch. > > > Thanks, > > Chun-Hung Hsiao > >
